network: properly remove connections from list

Due to a typo we were always removing the first (index 0) connection
from the global list of connections instead of the correct one.

This resulted in some connections remaining in the shell's connection
list long after they were removed.  In particular, this resulted in
multiple copies of a bluetooth connection appearing after suspend/resume
(when the device was readded and the cached connection list was
rescanned).

https://bugzilla.gnome.org/show_bug.cgi?id=740227

diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index 728584c1ba728f930b8519f11325d5804858fd96..459d51dd5db7221aa46a4d5f453dbd7c52ce2592 100644 (file)
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -1867,7 +1867,7 @@ const NMApplet = new Lang.Class({
     _connectionRemoved: function(connection) {
         let pos = this._connections.indexOf(connection);
         if (pos != -1)
-            this._connections.splice(connection, 1);
+            this._connections.splice(pos, 1);
 
         let section = connection._section;